Magic PR Journeys

March 22, 2021

Practical PRs

I was recently having a conversation about Pull Request reviews with a colleague of mine and I mentioned that when I’m ready to look at code for a PR, I review one commit at a time in order. After a confused pause, she asked how I could get the full context by only looking at one commit at a time. I supposed to her that perhaps the full context is not what facilitates a better review. Instead, we should follow the journey the developer who opened the PR has set out for us through their commits.

I have many more thoughts on this subject, but I’d like to hear yours too. Email me at chris@codegoalie.com and let me know what you think about the above supposition. Possible? Nonsensical? Outright dumb? :)

Here’s to your next magical PR journey!

— Chris

Image

Christopher R Marshall

@codegoalie

Enjoys programming web applications; especially in Go and Ruby. Also enjoys playing ice hockey as a goalie and playing the guitar.

Categories

I'll send it to you

Email versions of my posts. Plus about once a month, I send a manually curated list of interesting things I've found around the web.

    We respect your privacy. No spam ever. Just a message from me to you. Unsubscribe at any time.